nav tabs on admin dashboard

node_modules/webpack/lib/optimize/LimitChunkCountPlugin.js

@@ -4,55 +4,75 @@
 */
 "use strict";
 
+const validateOptions = require("schema-utils");
+const schema = require("../../schemas/plugins/optimize/LimitChunkCountPlugin.json");
+
+/** @typedef {import("../../declarations/plugins/optimize/LimitChunkCountPlugin").LimitChunkCountPluginOptions} LimitChunkCountPluginOptions */
+
 class LimitChunkCountPlugin {
+	/**
+	 * @param {LimitChunkCountPluginOptions=} options options object
+	 */
 	constructor(options) {
-		if(options !== undefined && typeof options !== "object" || Array.isArray(options)) {
-			throw new Error("Argument should be an options object.\nFor more info on options, see https://webpack.js.org/plugins/");
-		}
-		this.options = options || {};
+		if (!options) options = {};
+
+		validateOptions(schema, options, "Limit Chunk Count Plugin");
+		this.options = options;
 	}
 	apply(compiler) {
 		const options = this.options;
-		compiler.plugin("compilation", (compilation) => {
-			compilation.plugin("optimize-chunks-advanced", (chunks) => {
-				const maxChunks = options.maxChunks;
-				if(!maxChunks) return;
-				if(maxChunks < 1) return;
-				if(chunks.length <= maxChunks) return;
+		compiler.hooks.compilation.tap("LimitChunkCountPlugin", compilation => {
+			compilation.hooks.optimizeChunksAdvanced.tap(
+				"LimitChunkCountPlugin",
+				chunks => {
+					const maxChunks = options.maxChunks;
+					if (!maxChunks) return;
+					if (maxChunks < 1) return;
+					if (chunks.length <= maxChunks) return;
 
-				if(chunks.length > maxChunks) {
-					const sortedExtendedPairCombinations = chunks.reduce((combinations, a, idx) => {
-						// create combination pairs
-						for(let i = 0; i < idx; i++) {
-							const b = chunks[i];
-							combinations.push([b, a]);
-						}
-						return combinations;
-					}, []).map((pair) => {
-						// extend combination pairs with size and integrated size
-						const a = pair[0].size(options);
-						const b = pair[1].size(options);
-						const ab = pair[0].integratedSize(pair[1], options);
-						return [a + b - ab, ab, pair[0], pair[1], a, b];
-					}).filter((extendedPair) => {
-						// filter pairs that do not have an integratedSize
-						// meaning they can NOT be integrated!
-						return extendedPair[1] !== false;
-					}).sort((a, b) => { // sadly javascript does an inplace sort here
-						// sort them by size
-						const diff = b[0] - a[0];
-						if(diff !== 0) return diff;
-						return a[1] - b[1];
-					});
+					const orderedChunks = chunks.slice().sort((a, b) => a.compareTo(b));
+
+					const sortedExtendedPairCombinations = orderedChunks
+						.reduce((combinations, a, idx) => {
+							// create combination pairs
+							for (let i = 0; i < idx; i++) {
+								const b = orderedChunks[i];
+								combinations.push([b, a]);
+							}
+							return combinations;
+						}, [])
+						.map(pair => {
+							// extend combination pairs with size and integrated size
+							const a = pair[0].size(options);
+							const b = pair[1].size(options);
+							const ab = pair[0].integratedSize(pair[1], options);
+							return [a + b - ab, ab, pair[0], pair[1], a, b];
+						})
+						.filter(extendedPair => {
+							// filter pairs that do not have an integratedSize
+							// meaning they can NOT be integrated!
+							return extendedPair[1] !== false;
+						})
+						.sort((a, b) => {
+							// sadly javascript does an inplace sort here
+							// sort them by size
+							const diff1 = b[0] - a[0];
+							if (diff1 !== 0) return diff1;
+							const diff2 = a[1] - b[1];
+							if (diff2 !== 0) return diff2;
+							const diff3 = a[2].compareTo(b[2]);
+							if (diff3 !== 0) return diff3;
+							return a[3].compareTo(b[3]);
+						});
 
 					const pair = sortedExtendedPairCombinations[0];
 
-					if(pair && pair[2].integrate(pair[3], "limit")) {
+					if (pair && pair[2].integrate(pair[3], "limit")) {
 						chunks.splice(chunks.indexOf(pair[3]), 1);
 						return true;
 					}
 				}
-			});
+			);
 		});
 	}
 }